Skip to content

REF: unnecessary method sharing with PeriodIndex #43825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

REF: unnecessary method sharing with PeriodIndex #43825

merged 1 commit into from
Oct 1, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added this to the 1.4 milestone Oct 1, 2021
@jreback jreback added Period Period data type Index Related to the Index class or subclasses Refactor Internal refactoring of code labels Oct 1, 2021
@jreback
Copy link
Contributor

jreback commented Oct 1, 2021

this is just moving things around (in the same file) + typing?

@jbrockmendel
Copy link
Member Author

yes, and remove a handful of is_period_dtype checks

@jreback jreback merged commit ad4e091 into pandas-dev:master Oct 1, 2021
@jbrockmendel jbrockmendel deleted the ref-dtlike-per branch October 1, 2021 02:06
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
@jbrockmendel @gasparitiago
REF: unnecessary method sharing with PeriodIndex (pandas-dev#43825)
a5a87d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Index Related to the Index class or subclasses Period Period data type Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback