Skip to content

CLN: enable reportInvalidStubStatement #43775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2021
Merged

CLN: enable reportInvalidStubStatement #43775

merged 1 commit into from
Sep 28, 2021

Conversation

twoertwein
Copy link
Member

Default values in stub files are not used by type checkers (and they might get out of sync with the implementation).

@twoertwein twoertwein changed the title enable reportInvalidStubStatement CLN: enable reportInvalidStubStatement Sep 28, 2021
@jreback jreback added the Typing type annotations, mypy/pyright type checking label Sep 28, 2021
@jreback jreback added this to the 1.4 milestone Sep 28, 2021
@jreback
Copy link
Contributor

jreback commented Sep 28, 2021

looks fine, can you rebase

@twoertwein
Copy link
Member Author

@jreback rebased & green

@jreback jreback merged commit 010ea17 into pandas-dev:master Sep 28, 2021
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
@twoertwein twoertwein deleted the stub branch May 26, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants