-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: Remove unused functions/variables #43753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks good, some failures |
A few of the private functions are only called by tests which caused them to fail. The only failing test now is codecov/patch for some reason. |
can you rebase |
@jreback rebased & green |
thanks @twoertwein did you need to turn on a pyright option to have this reported? e.g. can we have it always run? (or is it expensive) |
I didn't turn them one because we have false-positives. We "exclude" pandas/tests - if we were to "ignore" pandas/tests, we probaly wouldn't have these false-positives anymore but pyright might be 30-50s slower if it has to work through the mostly un-typed tests. The four options from pyright are:
|
Found by pyright's
reportUnused*
.Unused functions/variables are not directly related to typing, but pyright warns about these cases because it is asked to do unnecessary work.