-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DEPS: Upgrade Deps for Python 3.10 #43729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 32 commits
f22feed
4d5ab7f
2cf1f0b
fc4329b
0360bae
98be5bd
4f406e5
c5d3021
1b043b6
1ec533f
5764d02
a68c546
7d3dd4c
e1745d6
94ea941
9c12e9c
1b686d5
2304615
5daaf27
435e9b1
79819ca
956a80b
9533da5
692ca3a
7cd2152
43316c3
6288e9e
a8fcee5
af883e5
5c30ced
cbcee65
ccb3b86
1d5a4b7
2f9f466
33178c4
58f2d36
0fb3755
6dcafea
3abc5a6
8cf70dd
542c5de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,6 @@ dependencies: | |
- xlwt | ||
- pip | ||
- pip: | ||
- cython>=0.29.21 | ||
- cython>=0.29.24 | ||
- pyreadstat | ||
- pyxlsb |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ classifiers = | |
Programming Language :: Python :: 3 :: Only | ||
Programming Language :: Python :: 3.8 | ||
Programming Language :: Python :: 3.9 | ||
Programming Language :: Python :: 3.10 | ||
Topic :: Scientific/Engineering | ||
project_urls = | ||
Bug Tracker = https://github.com/pandas-dev/pandas/issues | ||
|
@@ -30,7 +31,10 @@ project_urls = | |
[options] | ||
packages = find: | ||
install_requires = | ||
numpy>=1.18.5 | ||
numpy>=1.18.5; platform_machine!='aarch64' and platform_machine!='arm64' and python_version<'3.10' | ||
numpy>=1.19.2; platform_machine=='aarch64' | ||
numpy>=1.20.0; platform_machine=='arm64' | ||
numpy>=1.21.0; python_version=='3.10' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason to list these out? If you are on Python 3.10, there simply won't be a version of Python older than 1.21, if you are on a special arch, same thing; so why limit it here? Also this exact string won't work when Python 3.11 comes along. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the feedback! The rationale behind listing it out is that I think its still possible for pip to attempt an install from the sdists of older numpys, which could be caused by other projects who pin numpy forcing e.g. numpy < 1.21, which will ultimately result in a compile error for numpy. I'm not too familiar with this stuff so could be wrong here. Regarding Python 3.11, we'll add a new entry for that when it releases, as I don't expect the 1.21 series to work with it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd still recommend There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah this is ok for now.
does this have entries here as well? |
||
python-dateutil>=2.8.1 | ||
pytz>=2020.1 | ||
python_requires = >=3.8 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only to work with py310. for older python, previous min of Cython is still ok?
We are backporting this PR? (if so will need to move release note and say that the minimum is for py310 only?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think ok to move to 1.3.4, this is only a build requirement so ok changing (esp for 3.10) on backport