Skip to content

BUG: Fix some index_col tests for pyarrow read_csv #43706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2021
Merged

BUG: Fix some index_col tests for pyarrow read_csv #43706

merged 4 commits into from
Sep 27, 2021

Conversation

lithomas1
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added Arrow pyarrow functionality IO CSV read_csv, to_csv labels Sep 23, 2021
@jreback jreback added this to the 1.4 milestone Sep 23, 2021
jreback
jreback requested changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @gfyoung

@jreback
Copy link
Contributor

jreback commented Sep 23, 2021

add this PR number on the same release note for the arrow reader

@lithomas1
Copy link
Member Author

add this PR number on the same release note for the arrow reader

This shouldn't be necessary, as its unreleased. I'm planning a lot more changes to the Arrow CSV reader to bring up somewhat up to par, and this would add clutter to the release notes.

@jreback
Copy link
Contributor

jreback commented Sep 27, 2021

add this PR number on the same release note for the arrow reader

This shouldn't be necessary, as its unreleased. I'm planning a lot more changes to the Arrow CSV reader to bring up somewhat up to par, and this would add clutter to the release notes.

it doesn't matter. the arrow change is now composed of multiple PRs which is totally fine (an alternative if you want is to link these follow PRs to the original at the top). The point is in theory we can point to a single issue / PR to have the full change.

@lithomas1 lithomas1 requested a review from jreback September 27, 2021 23:26
@jreback jreback merged commit 7692d28 into pandas-dev:master Sep 27, 2021
@jreback
Copy link
Contributor

jreback commented Sep 27, 2021

thanks @lithomas1

@lithomas1 lithomas1 deleted the fix-arrow-csv branch December 8, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lithomas1 @jreback