Skip to content

TST: Make network tests run twice #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2013

Conversation

jtratner
Copy link
Contributor

Might help with issues like #4242

cc @cpcloud

@cpcloud
Copy link
Member

cpcloud commented Jul 26, 2013

looks good, @jreback ?

@jreback
Copy link
Contributor

jreback commented Jul 26, 2013

this is just a try it out..right...still don't really know why these tests occasionally fail?

@cpcloud
Copy link
Member

cpcloud commented Jul 26, 2013

yep the latest from #4357 is very weird...so yeah maybe wait to merge...should really try to get to the bottom of this

@jreback
Copy link
Contributor

jreback commented Jul 26, 2013

its a nice fix ...maybe it will work....up2u

@cpcloud
Copy link
Member

cpcloud commented Jul 26, 2013

i like this, but i don't think it will fix #4357 (a separate but related issue) ... would certainly help a lot with consistent errors tho so i'm going to merge.

cpcloud added a commit that referenced this pull request Jul 26, 2013
@cpcloud cpcloud merged commit 6d9fa7f into pandas-dev:master Jul 26, 2013
@cpcloud
Copy link
Member

cpcloud commented Jul 26, 2013

thanks @jtratner!

@cpcloud
Copy link
Member

cpcloud commented Jul 26, 2013

even tho #4357 is consistent from the OP's end, everyone else is having trouble reproducing it...so fyi by consistent i mean reproducible by at least 2 people ... maybe that's too strict...

that's definitely not saying that there isn't an issue there, there certainly is and it needs fixing

just wanted to clarify my statement above

@jtratner jtratner deleted the make-network-tests-run-twice branch September 21, 2013 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants