-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: simplify Styler._translate
#43686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 41 commits into
pandas-dev:master
from
attack68:clean_styler_css_classes
Oct 16, 2021
Merged
Changes from 19 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
7903723
clean up code
attack68 6a2793c
row, col and level css
attack68 d227914
whats new
attack68 7ca5002
tests and user guide
attack68 f27f7ed
merge
attack68 a1000a7
merge
attack68 021bc26
docs
attack68 4ba3dff
docs
attack68 7fee05d
more explicit test
attack68 baa3233
more explicit test
attack68 f4ad390
fix checks
attack68 22b03e3
fix checks
attack68 db214d8
fix checks
attack68 24952ae
fix checks
attack68 1d47d0f
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 566738d
fix checks
attack68 230138a
fix checks
attack68 b9ba9ea
refactor to get tests to pass
attack68 ea2bba1
refactor to get tests to pass
attack68 ca70491
correct css classes in set_table_styles
attack68 7a1994e
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 91320f8
add version added
attack68 92c1941
add version added
attack68 aad0e16
checks fix
attack68 61b24ed
add tests allow none
attack68 d4c5715
fix checks
attack68 aa0172f
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 84a814f
rename `css` `css_class_names`
attack68 f06b727
rename `css` `css_class_names`
attack68 131070f
rename `css` `css_class_names`
attack68 a048122
update arg name
attack68 4931f32
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 e9716f2
fix line length
attack68 d983464
black
attack68 16946b0
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 6e71e8c
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 1aa7c55
remove css_ids
attack68 d567d55
remove css_class_names from constructor
attack68 9d3c177
remove css_class_names from constructor
attack68 f0b3a20
update docs
attack68 f945ac8
Merge remote-tracking branch 'upstream/master' into clean_styler_css_…
attack68 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you are adding this to set_table_styles, do we need to add here (not a big deal but we already have a lot of options)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for preference I prefer to. most dont import
Styler
class but those who do might use it, and there are unlikely to be many more options added here in futures so this may be the last...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am confused over how this interacts with table_styles. can you either remove this enitrely or clarify.