Skip to content

REF: simplify IndexEngine signature #43661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2021
Merged

REF: simplify IndexEngine signature #43661

merged 2 commits into from
Sep 20, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jreback
jreback requested changes Sep 19, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make the engine non lazy?

@jbrockmendel
Copy link
Member Author

does this make the engine non lazy?

Populating the hashtable is still lazy

@jreback jreback added the Index Related to the Index class or subclasses label Sep 20, 2021
@jreback jreback added this to the 1.4 milestone Sep 20, 2021
@jreback jreback merged commit d09adae into pandas-dev:master Sep 20, 2021
@jbrockmendel jbrockmendel deleted the ref-vgetter branch September 20, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback