PERF: sparse take #43654
Merged
PERF: sparse take #43654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
Indexing
mzeitlin11
commented
Sep 19, 2021
| tm.assert_sp_array_equal(result, expected) | ||
|
|
||
| result = sparse.take(np.array([1, 0, -1]), fill_value=True) | ||
| expected = SparseArray([np.nan, np.nan, np.nan], kind="block") | ||
| expected = SparseArray([np.nan, np.nan, np.nan], kind=kind) |
There was a problem hiding this comment.
In all other take cases, we preserve the kind of SparseIndex, so I think it makes sense to do so here (otherwise is surprising value-dependent behavior IMO, somewhat expressed in the comment originally here).
mzeitlin11
commented
Sep 19, 2021
|
|
||
| return taken | ||
| new_sp_index = make_sparse_index(len(indices), value_indices, kind=self.kind) | ||
| return type(self)._simple_new(new_sp_values, new_sp_index, dtype=self.dtype) |
There was a problem hiding this comment.
Main reasoning for the simplifications here keeping same behavior is that take with allow_fill=False should give a result with the same dtype as our SparseArray
|
lgtm. cc @jbrockmendel |
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -354,6 +354,7 @@ Performance improvements | |||
| - Performance improvement in indexing with a :class:`MultiIndex` indexer on another :class:`MultiIndex` (:issue:43370`) | |||
| - Performance improvement in :meth:`GroupBy.quantile` (:issue:`43469`) | |||
| - :meth:`SparseArray.min` and :meth:`SparseArray.max` no longer require converting to a dense array (:issue:`43526`) | |||
| - Performance improvement in :meth:`SparseArray.take` with ``allow_fill=False`` (:issue:`?`) | |||
mzeitlin11
commented
Sep 20, 2021
jreback
approved these changes
Sep 21, 2021
|
thanks @mzeitlin11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps some on #41023 because
__getitem__usestakeinternally forSparseArray. However, the big gain there can follow after this to move towards not densifying on__getitem__with a sliceBenchmarks: