-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: azure timeouts #43643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: azure timeouts #43643
Conversation
Maybe something similar to HypothesisWorks/hypothesis#2340? |
Hmm this didn't work - new guess - the logging seems to stop around parser tests - maybe the fact that we use the same parser object across tests can cause deadlock (or issue is some mutation is happening?) |
We're at ~5 in a row on azure not timing out. Will keep running azure, but this is ready for review from my side. Summary of changes:
|
is there some option that can set on hypthosesis instead? the point of these tests is to find holes in our tests, which are almost all fast, so this just remove this entirely (which maybe ok). but then we should just do that. |
@@ -16,6 +16,7 @@ | |||
import pandas._testing as tm | |||
|
|||
xfail_pyarrow = pytest.mark.usefixtures("pyarrow_xfail") | |||
skip_pyarrow = pytest.mark.usefixtures("pyarrow_skip") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some comments here on when to xfail vs skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will do
We could set fewer examples to run (but at some point that defeats the purpose of Regardless, the important change here is skipping |
kk lgtm. ping when ready to merge (or just go ahead) |
note that I think we are seeing something similar on 1.3.4, but we didn't merge the pyarrow csv reader so prob something else. |
Good to know - certainly possible there are other potential timeout-causing issues unrelated to pyarrow. Will keep running azure pipelines on #43611 to see if anything else comes up. This should at least make timeouts less frequently hopefully |
thanks @mzeitlin11 nice improvement here. Yeah let's keep an eye on 1.3.4 |
Based on the logging in #43611, in both timeout cases, the last test
gw0
ran was before the hypothesis test intest_parse_dates
(this is a giant test - 56 parameterizations, hypothesis does 100 examples by default).Not sure why this would be the cause, couldn't find any issues about it that might explain a deadlock or something like that, but maybe this will help? Regardless of fixing timeouts, it makes sense for these to be slow