BUG: Groupby-Apply with modifying dataframe and sorting overwrites group values #43620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
changed the title
jreback
reviewed
Sep 17, 2021
| @@ -171,6 +171,10 @@ class providing the base-class of operations. | |||
| The resulting dtype will reflect the return value of the passed ``func``, | |||
| see the examples below. | |||
|
|
|||
| Functions that mutate the passed object can produce unexpected | |||
There was a problem hiding this comment.
this should be in Notes (wouldn't object to having this as a warning)
There was a problem hiding this comment.
My apologies, I'm new to contributing. Did I put my additional note in the incorrect 'Notes' section? @jreback
mroeschke
approved these changes
Oct 16, 2021
|
Great! Thanks @kasmith11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #36602