Skip to content

CLN: let codecs validate the possible values of encoding and encoding errors #43616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2021
Merged

CLN: let codecs validate the possible values of encoding and encoding errors #43616

merged 2 commits into from
Sep 17, 2021

Conversation

twoertwein
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

This makes the errors checking in get_handle simpler and consistent with the XML code.

@jreback jreback added the Clean label Sep 17, 2021
@jreback jreback added this to the 1.4 milestone Sep 17, 2021
@jreback jreback added the IO Data IO issues that don't fit into a more specific label label Sep 17, 2021
@jreback jreback merged commit 72a1090 into pandas-dev:master Sep 17, 2021
@jreback
Copy link
Contributor

jreback commented Sep 17, 2021

thanks @twoertwein

@twoertwein twoertwein deleted the xml branch September 22, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @jreback