-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Add back CircleCI for ARM64 #43613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wow @lithomas1 do I need to enable anything on the pandas repo for this to work? |
Yeah. I think you need to go here https://app.circleci.com/projects/project-dashboard/github/pandas-dev/ and click the setup button for the pandas repo. It'll probably better if this is merged first so that CircleCI can detect the config file. Then, I think in Project Settings > Advanced we should probably Build Forked Pull Requests, and Auto Cancel Redundant Builds, but the only thing that really needs to be on is Free and Open Source(it should be on by default, but can't hurt to double-check). |
ok done. Build Forked PRs was already checked as was auto cancel. |
ok let's see how this goes |
Nice. Just a heads up that a lot of PRs will be red unless they merge master, since Circle needs the config to run. |
that's fine |
@meeseeksdev backport 1.3.x |
Successful run https://app.circleci.com/pipelines/github/lithomas1/pandas/3/workflows/ebe9e4aa-f86b-4bb2-9324-2b7a5eb9c243/jobs/3 (my fork)
I think someone with admin permissions in the github organization needs to turn on CircleCi on the pandas repo again. It probably would be better if this were merged first.
I also figured out how the credits work. Basically there's a setting for it in project settings. I think it should already be on.

(my fork settings)