Skip to content

CI: Add back CircleCI for ARM64 #43613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Sep 16, 2021

Successful run https://app.circleci.com/pipelines/github/lithomas1/pandas/3/workflows/ebe9e4aa-f86b-4bb2-9324-2b7a5eb9c243/jobs/3 (my fork)

I think someone with admin permissions in the github organization needs to turn on CircleCi on the pandas repo again. It probably would be better if this were merged first.

I also figured out how the credits work. Basically there's a setting for it in project settings. I think it should already be on.
image
(my fork settings)

@jreback
Copy link
Contributor

jreback commented Sep 16, 2021

wow @lithomas1 do I need to enable anything on the pandas repo for this to work?

@jreback jreback added ARM aarch64 architecture CI Continuous Integration labels Sep 16, 2021
@lithomas1
Copy link
Member Author

Yeah. I think you need to go here https://app.circleci.com/projects/project-dashboard/github/pandas-dev/ and click the setup button for the pandas repo. It'll probably better if this is merged first so that CircleCI can detect the config file.

Then, I think in Project Settings > Advanced we should probably Build Forked Pull Requests, and Auto Cancel Redundant Builds, but the only thing that really needs to be on is Free and Open Source(it should be on by default, but can't hurt to double-check).

@jreback jreback added this to the 1.4 milestone Sep 16, 2021
@jreback jreback merged commit f08c702 into pandas-dev:master Sep 16, 2021
@jreback
Copy link
Contributor

jreback commented Sep 16, 2021

ok done. Build Forked PRs was already checked as was auto cancel.

@jreback
Copy link
Contributor

jreback commented Sep 16, 2021

ok let's see how this goes

@lithomas1 lithomas1 deleted the circleci-project-setup branch September 16, 2021 22:47
@lithomas1
Copy link
Member Author

Nice. Just a heads up that a lot of PRs will be red unless they merge master, since Circle needs the config to run.

@jreback
Copy link
Contributor

jreback commented Sep 16, 2021

that's fine

@lithomas1
Copy link
Member Author

@meeseeksdev backport 1.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM aarch64 architecture CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Re-enable Circle CI
2 participants