Skip to content

PERF: grouped_reduce #43576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

PERF: grouped_reduce #43576

merged 1 commit into from
Sep 15, 2021

Conversation

jbrockmendel
Copy link
Member 

from asv_bench.benchmarks.groupby import *
self = GroupByMethods()
self.setup("int", "std", "transformation", 10)

%timeit self.time_dtype_as_field('int', 'std', 'transformation', 10)
325 µs ± 9.84 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)  # <- PR
361 µs ± 2.05 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)  # <- master

@jbrockmendel jbrockmendel added the Performance Memory or execution speed performance label Sep 15, 2021
@jreback jreback added this to the 1.4 milestone Sep 15, 2021
jreback
jreback reviewed Sep 15, 2021
View reviewed changes
pandas/core/internals/managers.py
@@ -1275,7 +1278,8 @@ def grouped_reduce(self: T, func: Callable, ignore_failures: bool = False) -> T:
else:
index = Index(range(result_blocks[0].values.shape[-1]))

if ignore_failures:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you kill ignore_failures now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, though we can get rid of it in 2.0 BC of the nuisance column derecations

@jreback jreback merged commit 5872bfe into pandas-dev:master Sep 15, 2021
@jbrockmendel jbrockmendel deleted the collect-apply branch September 15, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback