TST/BUG/CLN: make stata IO tests use temporary files for writing #4356
+41
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitya57 can you confirm that this works for you? |
|
Yes, it works for me. Thanks! |
ghost
assigned
|
@mitya57 Do all test pass for you? There are quite a few other places where file writing occurs where an explicit path is passed. |
|
I do get some other failures locally (i.e. https://gist.github.com/mitya57/5910851), but they are unrelated to permissions issue and don't happen on Jenkins, so you may ignore those. |
|
second one is an old bug that has been fixed...not sure about the other two |
cpcloud
added a commit
that referenced
this pull request
Jul 25, 2013
TST/BUG/CLN: make stata IO tests use temporary files for writing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4353