REGR: Outer merge failing with integer and NaN keys #43553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
debnathshoham
commented
Sep 13, 2021
debnathshoham
commented
- closes REGR: outer join with integer key and NaNs failing #43550
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
reviewed
Sep 13, 2021
| @@ -2571,3 +2571,18 @@ def test_mergeerror_on_left_index_mismatched_dtypes(): | |||
| df_2 = DataFrame(data=["X"], columns=["C"], index=[999]) | |||
| with pytest.raises(MergeError, match="Can only pass argument"): | |||
| merge(df_1, df_2, on=["C"], left_index=True) | |||
|
|
|||
|
|
|||
| def test_merge_outer_with_NaN(): | |||
There was a problem hiding this comment.
can you parameterize with Int64 as well
There was a problem hiding this comment.
Can we switch left and right too? Changing lvals to rvals above would have fixed the issue but caused the inverse to fail
phofl
approved these changes
Sep 14, 2021
|
thx @debnathshoham |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 14, 2021
jreback
pushed a commit
that referenced
this pull request
Sep 14, 2021
…ys (#43566) Co-authored-by: Shoham Debnath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.