Refactor/validate utils #43551
Merged
Refactor/validate utils #43551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zyc09
commented
Sep 13, 2021
zyc09
commented
- refactoring for ENH: consistency of input args for boundaries #40245
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Sep 13, 2021
pandas/util/_validators.py
Outdated
| @@ -427,3 +427,70 @@ def validate_ascending( | |||
| return validate_bool_kwarg(ascending, "ascending", **kwargs) | |||
|
|
|||
| return [validate_bool_kwarg(item, "ascending", **kwargs) for item in ascending] | |||
|
|
|||
|
|
|||
| def validate_endpoints(closed): | |||
There was a problem hiding this comment.
can you type this (input & output)
pandas/util/_validators.py
Outdated
| return left_closed, right_closed | ||
|
|
||
|
|
||
| def validate_inclusive(inclusive): |
jreback
approved these changes
Sep 14, 2021
jreback
requested changes
Sep 14, 2021
pandas/util/_validators.py
Outdated
| @@ -427,3 +428,70 @@ def validate_ascending( | |||
| return validate_bool_kwarg(ascending, "ascending", **kwargs) | |||
|
|
|||
| return [validate_bool_kwarg(item, "ascending", **kwargs) for item in ascending] | |||
|
|
|||
|
|
|||
| def validate_endpoints(closed: Any) -> tuple[bool, bool]: | |||
There was a problem hiding this comment.
hmm this should be Optional[str]
pandas/util/_validators.py
Outdated
| return left_closed, right_closed | ||
|
|
||
|
|
||
| def validate_inclusive(inclusive: Any) -> tuple[bool, bool]: |
There was a problem hiding this comment.
oof, let me amend that
jreback
approved these changes
Sep 14, 2021
|
thanks @zyc09 very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.