Skip to content

split macos tests in 2 #43517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2021
Merged

split macos tests in 2 #43517

merged 2 commits into from
Sep 12, 2021

Conversation

Dr-Irv
Copy link
Contributor

@Dr-Irv Dr-Irv commented Sep 11, 2021

follow up to #43468 to also split MacOS tests in half to speed up CI tests per comment from @jreback #43468 (comment)

@Dr-Irv Dr-Irv added Testing pandas testing functions or related to the test suite CI Continuous Integration OS X Related to Mac OS & hardware issues (M1) labels Sep 11, 2021
@mzeitlin11
Copy link
Member

On a run like https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=66005&view=results, the test distribution looks like windows1: gw0 [104233] / gw1 [104233], windows2: gw0 [26865] / gw1 [26865] and windows1 seems to take generally longer (and saw a timeout yesterday, can't remember which pr). Maybe we can add a few more letters to the second job to even out?

@jbrockmendel
Copy link
Member

Looking at the Windows timeouts, the last lines before the timeout nearly all look like they are making HTTP requests, e.g.

....ss......ss......ss.x.x.xxss......ss......ss......ss................127.0.0.1 - - [10/Sep/2021 21:05:19] "GET / HTTP/1.1" 200 -

I could totally imagine something in the network stack blocking and not having a timeout set.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Sep 11, 2021

On a run like https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=66005&view=results, the test distribution looks like windows1: gw0 [104233] / gw1 [104233], windows2: gw0 [26865] / gw1 [26865] and windows1 seems to take generally longer (and saw a timeout yesterday, can't remember which pr). Maybe we can add a few more letters to the second job to even out?

Good observation. I moved it by one letter. There are a lot of tests in the "i" category, so let's see how this change helps.

@Dr-Irv
Copy link
Contributor Author

Dr-Irv commented Sep 11, 2021

Split now gw0 [74211] / gw1 [74211] on Windows1 and gw0 [56887] / gw1 [56887] on Windows2

@jreback jreback added this to the 1.3.4 milestone Sep 12, 2021
@jreback jreback merged commit dfbc76e into pandas-dev:master Sep 12, 2021
@jreback
Copy link
Contributor

jreback commented Sep 12, 2021

thanks @Dr-Irv

@lumberbot-app

This comment has been minimized.

@jreback
Copy link
Contributor

jreback commented Sep 12, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app

This comment has been minimized.

Dr-Irv added a commit to Dr-Irv/pandas that referenced this pull request Sep 12, 2021
lithomas1 pushed a commit that referenced this pull request Sep 13, 2021
* Backport PR #43468: CI: split Windows Azure tests in half

* split macos tests in 2 (#43517)

* fix macos backport to use 3.7
AlexeyGy pushed a commit to AlexeyGy/pandas that referenced this pull request Sep 13, 2021
AlexeyGy pushed a commit to AlexeyGy/pandas that referenced this pull request Sep 13, 2021
@Dr-Irv Dr-Irv deleted the ci_macos branch February 13, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration OS X Related to Mac OS & hardware issues (M1) Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants