-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: remove libreduction.SeriesGrouper #43505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -811,7 +811,7 @@ def test_categoricals(a_dtype, b_dtype): | |||
a_is_cat = is_categorical_dtype(a.dtype) | |||
assert not a_is_cat or a.value_counts().loc[1] == 0 | |||
result = crosstab(a, b, margins=True, dropna=False) | |||
values = [[18, 16, 34], [0, 0, np.nan], [34, 32, 66], [52, 48, 100]] | |||
values = [[18, 16, 34], [0, 0, 0], [34, 32, 66], [52, 48, 100]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may want to add a note for this (i agree that this looks more correct)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
I agree that this looks like a bug fix too. |
@bashtage can i pawn off the writing of a whatsnew on you? i have zero experience with crosstab |
What's new in #43548 |
cc @bashtage per comment #37468 (comment) I'm taking your word for it that the change this makes in the crosstab test is correct. Does this represent a bugfix?