REF: dont pass keys through wrap_applied_output #43479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 9, 2021
pandas/core/groupby/ops.py
Outdated
| @@ -726,10 +726,15 @@ def _get_group_keys(self): | |||
| return get_flattened_list(ids, ngroups, self.levels, self.codes) | |||
|
|
|||
| @final | |||
| def apply(self, f: F, data: FrameOrSeries, axis: int = 0): | |||
| @cache_readonly | |||
| def group_keys_seq(self): | |||
There was a problem hiding this comment.
without adding this, the PR makes us call _get_group_keys repeatedly; this is a cached version of that call
There was a problem hiding this comment.
updated to just remove _get_group_keys and only have the cached version
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to reason about these
keys, which I'm hopeful will lead to getting rid of them entirely and just using result_index.