-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: add links to pre-commit in contributing #43441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full stop is missing. Can you also post a screenshot to show that this renders correctly?
thanks for spotting this - indeed, since the docs were reorganised, "code standards" is in a different page. Could you also change the pull request template to link to https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#pre-commit then please?
You can just build the doc page you've edited using |
Aah, yes, I was initially thinking of elaborating in the contributing page, which was what this was for. Now this does both. the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the --single cannot find the file, I guess that needs more fumbling around ;)
can you show the command you ran?
Can you address https://github.com/pandas-dev/pandas/pull/43441/files#r703676173 please? |
Sorry, I had solved it locally but I didn't know that not all branches get pushed when I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joeperdefloep |
The contributing page has comments on style, but does not link to setting up pre-commits yourself. It would be nice to be guided there