Skip to content

ENH: Improve IOError handling on missing parent directory for Series/DataFrame write methods #24306 #43436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 11, 2021
Merged

ENH: Improve IOError handling on missing parent directory for Series/DataFrame write methods #24306 #43436

merged 17 commits into from
Sep 11, 2021

Conversation

leonarduschen
Copy link
Contributor

@leonarduschen leonarduschen commented Sep 7, 2021 •
edited
Loading

@leonarduschen leonarduschen marked this pull request as ready for review September 7, 2021 14:45
leonarduschen
leonarduschen commented Sep 7, 2021
View reviewed changes
@leonarduschen leonarduschen changed the title ENH: Raise exception for missing parent directory for to_* methods #24306 ENH: Improve error message on missing parent directory for NDArray.to_* methods #24306 Sep 7, 2021
@leonarduschen leonarduschen changed the title ENH: Improve error message on missing parent directory for NDArray.to_* methods #24306 ENH: Improve IOError handling on missing parent directory for Series/DataFrame write methods #24306 Sep 7, 2021
jreback
jreback requested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twoertwein if you can have a look

@jreback jreback added Error Reporting Incorrect or improved errors from pandas IO Data IO issues that don't fit into a more specific label labels Sep 7, 2021
@jreback jreback added this to the 1.4 milestone Sep 7, 2021
twoertwein
twoertwein reviewed Sep 8, 2021
View reviewed changes
leonarduschen
leonarduschen commented Sep 8, 2021
View reviewed changes
Copy link
Contributor Author

@leonarduschen leonarduschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change here because we changed os.path.dirname to pathlib.Path.parent

@leonarduschen
Copy link
Contributor Author

leonarduschen commented Sep 9, 2021 •
edited
Loading

alright tests are good here except for the timed-out one - which seems to occur in other PRs as well

@jreback
Copy link
Contributor

jreback commented Sep 9, 2021

@twoertwein good here?

@leonarduschen
Copy link
Contributor Author

should I resolve the merge conflict?

@lithomas1
Copy link
Member

lithomas1 commented Sep 10, 2021 •
edited
Loading

Yup. Thanks for the PR! We'll get it merged afterwards.

@leonarduschen leonarduschen force-pushed the improve-missing-directory-error-message branch from 76cbe64 to 069a2de Compare September 11, 2021 04:30
@leonarduschen
Copy link
Contributor Author

Alright done

@jreback jreback merged commit fb32477 into pandas-dev:master Sep 11, 2021
@jreback
Copy link
Contributor

jreback commented Sep 11, 2021

thanks @leonarduschen very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@twoertwein twoertwein twoertwein approved these changes

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

to_csv - allow to create folders.
4 participants
@leonarduschen @jreback @lithomas1 @twoertwein