REF: Groupby._get_cythonized_result operate blockwise in axis==1 case #43435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Sep 7, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jbrockmendel
commented
Sep 7, 2021
pandas/core/groupby/groupby.py
Outdated
| error_msg = str(err) | ||
| raise TypeError(error_msg) | ||
| # We should never get here | ||
| raise TypeError("All columns were dropped in grouped_reduce") |
There was a problem hiding this comment.
luckily we'll be able to get rid of L3028-L3047 once the deprecation is enforced
|
needs a rebase, b ut i think you have changed a bunch of this code |
|
rebased + green |
jreback
added
the
Missing-data
|
is this a bug fix? or just perf on a case? |
Neither, just going from 2 paths to 1 path. |
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.