TST: Test for MultiIndex merge with CategoricalIndex (#36973) #43433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tim-tran
commented
Sep 6, 2021
•
tim-tran
commented
- closes BUG: merge with MultiIndex including a CategoricalIndex returns wrong result when values are ordered specifically #36973
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
jreback
reviewed
Sep 7, 2021
| @@ -2542,3 +2542,32 @@ def test_mergeerror_on_left_index_mismatched_dtypes(): | |||
| df_2 = DataFrame(data=["X"], columns=["C"], index=[999]) | |||
| with pytest.raises(MergeError, match="Can only pass argument"): | |||
| merge(df_1, df_2, on=["C"], left_index=True) | |||
|
|
|||
|
|
|||
| def test_multiindex_merge_with_unordered_categoricalindex(): | |||
There was a problem hiding this comment.
can you parametrized over ordered=True/False (test name can stay the same)
There was a problem hiding this comment.
can you locate this test near other catorical merge tests
test_merge_categorical
tests_merge_categorical_unordered_equal # maybe a dupe of this one
if not a dupe, then ok to add this test
There was a problem hiding this comment.
Sure thing. It doesn't look like the test is a duplicate
jreback
added
Categorical
|
thanks @tim-tran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.