Skip to content

DOC: Modify pandas.ExcelWriter default engine in docstring (#43359) #43432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2021

Conversation

LiquidMika
Copy link
Contributor

@LiquidMika LiquidMika commented Sep 6, 2021

  • engine for xlsx : xlsxwriter instead of openpyxl
  • correction to pass the doctest

Script validate_docstings report : validate_docstrings.txt

…v#43359)

* engine for xlsx : xlsxwriter instead of openpyxl
* correction to pass the doctest
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback added Docs IO Excel read_excel, to_excel labels Sep 9, 2021
…v#43359)

Correction after after pull review

* engine for xlsx : xlsxwriter instead of openpyxl
* correction to pass the doctest
…v#43359)

Correction to pass test
    * engine for xlsx : xlsxwriter instead of openpyxl
    * correction to pass the doctest
@mroeschke mroeschke added this to the 1.4 milestone Sep 12, 2021
@mroeschke mroeschke merged commit 044ab26 into pandas-dev:master Sep 12, 2021
@mroeschke
Copy link
Member

Thanks @LiquidMika

AlexeyGy pushed a commit to AlexeyGy/pandas that referenced this pull request Sep 13, 2021
…v#43359) (pandas-dev#43432)

* DOC: Modify pandas.ExcelWriter default engine in docstring (pandas-dev#43359)

* engine for xlsx : xlsxwriter instead of openpyxl
* correction to pass the doctest

* DOC: Modify pandas.ExcelWriter default engine in docstring (pandas-dev#43359)
Correction after after pull review

* engine for xlsx : xlsxwriter instead of openpyxl
* correction to pass the doctest

* DOC: Modify pandas.ExcelWriter default engine in docstring (pandas-dev#43359)
Correction to pass test
    * engine for xlsx : xlsxwriter instead of openpyxl
    * correction to pass the doctest
AlexeyGy pushed a commit to AlexeyGy/pandas that referenced this pull request Sep 13, 2021
…v#43359) (pandas-dev#43432)

* DOC: Modify pandas.ExcelWriter default engine in docstring (pandas-dev#43359)

* engine for xlsx : xlsxwriter instead of openpyxl
* correction to pass the doctest

* DOC: Modify pandas.ExcelWriter default engine in docstring (pandas-dev#43359)
Correction after after pull review

* engine for xlsx : xlsxwriter instead of openpyxl
* correction to pass the doctest

* DOC: Modify pandas.ExcelWriter default engine in docstring (pandas-dev#43359)
Correction to pass test
    * engine for xlsx : xlsxwriter instead of openpyxl
    * correction to pass the doctest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Default engine incorrect for ExcelWriter and xlsx
4 participants