PERF: MultiIndex.get_indexer #43370
Merged
PERF: MultiIndex.get_indexer #43370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Indexing
jreback
approved these changes
Sep 5, 2021
| @@ -603,35 +603,34 @@ cdef class BaseMultiIndexCodesEngine: | |||
| def _codes_to_ints(self, ndarray[uint64_t] codes) -> np.ndarray: | |||
| raise NotImplementedError("Implemented by subclass") | |||
|
|
|||
| def _extract_level_codes(self, ndarray[object] target) -> np.ndarray: | |||
| def _extract_level_codes(self, target) -> np.ndarray: | |||
There was a problem hiding this comment.
yah mentioned in OP plans for follow-on to restore common signature/typing
| return self._codes_to_ints(np.array(level_codes, dtype='uint64').T) | ||
|
|
||
| def get_indexer(self, ndarray[object] target) -> np.ndarray: | ||
| def get_indexer(self, target) -> np.ndarray: |
| def get_indexer_non_unique(self, ndarray[object] target): | ||
|
|
||
| def get_indexer_non_unique(self, target): | ||
| # target: MultiIndex |
jreback
reviewed
Sep 5, 2021
| @@ -3619,7 +3619,12 @@ def _get_indexer( | |||
| elif method == "nearest": | |||
| indexer = self._get_nearest_indexer(target, limit, tolerance) | |||
| else: | |||
| indexer = self._engine.get_indexer(target._get_engine_target()) | |||
| tgt_values = target._get_engine_target() | |||
| if target._is_multi and self._is_multi: | |||
There was a problem hiding this comment.
might be worth a comment here and L5453 that this is for perf as not super obvious
|
lgtm but if you can add some comments, ping on green |
|
ok fair enough all of this is fine for a followon. |
|
also since this is a huge speedup this migth improve some concat / join asvs for multi-multi (if so that is worth a whatsnew note0 |
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 5, 2021
jreback
pushed a commit
that referenced
this pull request
Sep 6, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids expensive construction of MultiIndex.values, followed by expensive casting of sequence-of-tuples back to tuple-of-Indexes.
Follow-up will move _extract_level_codes out of cython so that Engine._get_indexer and Engine._get_indexer_non_unique are restored to having consistent signatures.