Skip to content

CI: Fix Failing Doc Build #43349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

alimcmaster1
Copy link
Member

#43145 had failing code checks

https://github.com/pandas-dev/pandas/pull/43347/checks?check_run_id=3488498926

/home/runner/work/pandas/pandas/doc/source/whatsnew/v1.3.3.rst:36: WARNING: Bullet list ends without a blank line; unexpected unindent.

@alimcmaster1 alimcmaster1 added Docs CI Continuous Integration labels Sep 1, 2021
@alimcmaster1 alimcmaster1 modified the milestones: 1.3.3, 1.4 Sep 1, 2021
@jreback
Copy link
Contributor

jreback commented Sep 1, 2021

wow! merge on green.

@jreback jreback modified the milestones: 1.4, 1.3.3 Sep 1, 2021
@jreback
Copy link
Contributor

jreback commented Sep 1, 2021

actually need to backport this

@jreback jreback merged commit 62c12cf into pandas-dev:master Sep 1, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 1, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 62c12cf09cdd77b35d404667d859fd90190aeb70
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #43349: CI: Fix Failing Doc Build'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-43349-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #43349 on branch 1.3.x (CI: Fix Failing Doc Build)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Sep 1, 2021

@meeseeksdev backport 1.3.x

@jreback
Copy link
Contributor

jreback commented Sep 1, 2021

thanks @alimcmaster1

@jreback
Copy link
Contributor

jreback commented Sep 1, 2021

grr i should have merged the other first :-<

jreback pushed a commit that referenced this pull request Sep 1, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants