Skip to content

PERF: read_sas #43333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

PERF: read_sas #43333

merged 1 commit into from
Sep 1, 2021

Conversation

jbrockmendel
Copy link
Member 

from asv_bench.benchmarks.io.sas import *
self8 = SAS()
self8.setup("sas7bdat")

%timeit self8.time_read_sas("sas7bdat")
41.6 ms ± 1.77 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- master
22.7 ms ± 1.04 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- PR

@jbrockmendel jbrockmendel added the Performance Memory or execution speed performance label Aug 31, 2021
@jreback jreback added this to the 1.4 milestone Aug 31, 2021
@jreback jreback added the IO SAS SAS: read_sas label Aug 31, 2021
jreback
jreback approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @bashtage if any comments, merge when ready

@jreback jreback merged commit e48174b into pandas-dev:master Sep 1, 2021
@jbrockmendel jbrockmendel deleted the perf-sas branch September 1, 2021 15:56
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@jbrockmendel @feefladder
PERF: read_sas (pandas-dev#43333)
34ccf05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@bashtage bashtage bashtage left review comments

Assignees
No one assigned
Labels
IO SAS SAS: read_sas Performance Memory or execution speed performance
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @bashtage