Skip to content

PERF: DataFrame[object].fillna #43316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

from asv_bench.benchmarks.frame_methods import *

self5 = Fillna()
self5.setup(False, 'pad', 'object')

%timeit self5.time_frame_fillna(False, 'pad', 'object')
191 ms ± 5.41 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)  # <- master
127 ms ± 5.03 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- PR

@jbrockmendel jbrockmendel added the Performance Memory or execution speed performance label Aug 31, 2021
@jreback jreback added this to the 1.4 milestone Aug 31, 2021
@jreback jreback added the Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate label Aug 31, 2021
@jreback
Copy link
Contributor

jreback commented Aug 31, 2021

can you rebase just to be sure

@jbrockmendel
Copy link
Member Author

rebased + green

@jreback jreback merged commit ba21475 into pandas-dev:master Sep 2, 2021
@jbrockmendel jbrockmendel deleted the perf-fillna branch September 3, 2021 01:13
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants