ENH: styler.html.mathjax option
#43283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
simonjayhawkins
added
Enhancement
IO HTML
# Conflicts: # doc/source/user_guide/options.rst # doc/source/whatsnew/v1.4.0.rst # pandas/core/config_init.py
jreback
reviewed
Aug 31, 2021
| @@ -250,8 +250,7 @@ def _translate(self, sparse_index: bool, sparse_cols: bool, blank: str = " | |||
| d.update({k: map}) | |||
|
|
|||
| table_attr = self.table_attributes | |||
| use_mathjax = get_option("display.html.use_mathjax") | |||
| if not use_mathjax: | |||
| if not get_option("styler.html.mathjax"): | |||
There was a problem hiding this comment.
so this is technically a change in the option name? (its ok to merge this, just mention in the whatsnew)
There was a problem hiding this comment.
done. I will edit the whats new before 1.4.0 release.
|
can you rebase |
# Conflicts: # doc/source/whatsnew/v1.4.0.rst # pandas/core/config_init.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pandas option is added to allow the
Styleroptions to be independent from the others. See #41395options.rstwill update styler user guide as a follow on when all options PRs merged.