TST: makeMultiIndex not respecting k parameter #43275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShreyasPatel031
commented
Aug 28, 2021
•
ShreyasPatel031
commented
- closes BUG: pd.testing.makeMultiIndex ignores k parameter #38795
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
Hello @ShreyasPatel031! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-28 18:19:23 UTC |
simonjayhawkins
added
the
Testing
phofl
reviewed
Aug 30, 2021
| return MultiIndex.from_product( | ||
| (rands_array(nchars=10, size=k), | ||
| randu_array(nchars=10, size=k)), | ||
| names=names, **kwargs) |
There was a problem hiding this comment.
Is there a way to test this efficiently to avoid future issues?
There was a problem hiding this comment.
should add a test in tests.util
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Appears this PR has been dormant for a while and needs updates so closing. If interested in continuing, please merge master, address related comments and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.