Skip to content

PERF: indexing #43274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 30, 2021
Merged

PERF: indexing #43274

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa9c714
PERF: indexing.InsertColumns.time_assign_with_setitem
debnathshoham Aug 28, 2021
9568c73
added whatsnew
debnathshoham Aug 28, 2021
9cad0b1
more descriptive whatsnew
debnathshoham Aug 29, 2021
1567d3c
rectified whatsnew
debnathshoham Aug 29, 2021
256f80f
added PR ref in whatsnew
debnathshoham Aug 30, 2021
ed10166
clear whatsnew
debnathshoham Aug 30, 2021
aaa5fdf
suggested change
debnathshoham Aug 30, 2021
549b39e
added blank line
debnathshoham Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/source/whatsnew/v1.3.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ Fixed regressions

.. ---------------------------------------------------------------------------

.. _whatsnew_133.performance:

Performance improvements
~~~~~~~~~~~~~~~~~~~~~~~~
- Performance improvement for :meth:`DataFrame.__setitem__`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify in which cases?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @phofl - updated. Let me know if this is fine.

-
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a blank line, docs aren't building like that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! I see. I was confused why the docs were consistently failing.

.. ---------------------------------------------------------------------------

.. _whatsnew_133.bug_fixes:

Bug fixes
Expand Down
8 changes: 5 additions & 3 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3620,9 +3620,11 @@ def __setitem__(self, key, value):
self._setitem_array(key, value)
elif isinstance(value, DataFrame):
self._set_item_frame_value(key, value)
elif is_list_like(value) and 1 < len(
self.columns.get_indexer_for([key])
) == len(value):
elif (
is_list_like(value)
and not self.columns.is_unique
and 1 < len(self.columns.get_indexer_for([key])) == len(value)
):
# Column to set is duplicated
self._setitem_array([key], value)
else:
Expand Down