TST: added test for ea dtypes conversion to datetimetzdtype (GH37553) #43270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzophys
changed the title
mzeitlin11
reviewed
Aug 28, 2021
There was a problem hiding this comment.
Thanks for the pr @lorenzophys! Just a small comment - right now the test uses only Series but is in frame/methods. I'd recommend either moving to series/methods or parametrizing using the frame_or_series fixture if that would make sense.
| } | ||
| ) | ||
|
|
||
| tm.assert_equal(result, expected) |
There was a problem hiding this comment.
If just comparing Series, could use tm.assert_series_equal. assert_equal is useful when doing something like parameterizing over DataFrame and Series (like with the frame_or_series fixture)
mzeitlin11
added
Dtype Conversions
|
Thank you for the review @mzeitlin11, the new location makes much more sense. |
mzeitlin11
approved these changes
Aug 28, 2021
|
thanks @lorenzophys |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided tests for type cast
ExtensionDtypes->DatetimeTZDtype.Tests and linter pass locally.