Skip to content

TST: added tests for to_json when called on complex data (GH41174) #43258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

TST: added tests for to_json when called on complex data (GH41174) #43258

merged 1 commit into from
Aug 30, 2021

Conversation

lorenzophys
Copy link
Contributor

@lorenzophys lorenzophys commented Aug 27, 2021 •
edited
Loading

Provided tests for to_json when called on complex data on both Series and DataFrame. Coefficients are both int and float.

Tests and linter pass locally.

mroeschke
mroeschke approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke added IO JSON read_json, to_json, json_normalize Testing pandas testing functions or related to the test suite labels Aug 27, 2021
@mroeschke mroeschke added this to the 1.4 milestone Aug 27, 2021
@simonjayhawkins simonjayhawkins merged commit 755119a into pandas-dev:master Aug 30, 2021
@simonjayhawkins
Copy link
Member

Thanks @lorenzophys

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@lorenzophys @feefladder
TST: added tests for to_json when called on complex data (GH41174) (p…
07aed07 
…andas-dev#43258)
@jbrockmendel jbrockmendel mentioned this pull request Oct 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO JSON read_json, to_json, json_normalize Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: Unexpected output of to_json for complex data
3 participants
@lorenzophys @simonjayhawkins @mroeschke