Bug in RangeIndex.where raising AssertionError when result is not from RangeIndex #43251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Index
| @@ -4890,8 +4890,7 @@ def putmask(self, mask, value) -> Index: | |||
| values, mask.sum(), converted # type: ignore[arg-type] | |||
| ) | |||
| np.putmask(values, mask, converted) | |||
|
|
|||
| return type(self)._simple_new(values, name=self.name) | |||
There was a problem hiding this comment.
this line also turns out to be wrong for the MultiIndex case, xref #43219
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 27, 2021
…onError when result is not from RangeIndex
|
Thanks @phofl |
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 28, 2021
…en result is not from RangeIndex (#43259) Co-authored-by: Patrick Hoefler <[email protected]>
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…m RangeIndex (pandas-dev#43251) * Fix promote issue in range putmask * Improve test and add whatsnew * Change issue reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RangeIndex.wherethrows AssertionError #43240cc @jbrockmendel
2 options here:
_shallow_copywhich handles the cast to Int64Index in theses cases_simple_newpassing the call through to Int64Index or Float64Index depending on the dtypeBut not sure if this would be counterintuitive for
_simple_new.