Skip to content

DOC PR09 Add "." on to_hdf format parameter #43246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2021
Merged

DOC PR09 Add "." on to_hdf format parameter #43246

merged 1 commit into from
Aug 27, 2021

Conversation

marvintensuan
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

From #28602:

pandas.Series.to_hdf: Parameter "format" description should finish with "."
pandas.DataFrame.to_hdf: Parameter "format" description should finish with "."

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - are there many more PR09 errors? If you wanted to take on more of them (even in the same PR) and that add this to the CI check, that'd be awesome

@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Aug 27, 2021
@MarcoGorelli MarcoGorelli merged commit cc5ef4f into pandas-dev:master Aug 27, 2021
@marvintensuan
Copy link
Contributor Author

@MarcoGorelli From what I've seen, these are all done:

pandas.read_excel: Parameter "usecols" description should finish with "."
pandas.read_sql: Parameter "con" description should finish with "."
pandas.DataFrame.corr: Parameter "method" description should finish with "."
pandas.Series.to_sql: Parameter "con" description should finish with "."
pandas.DataFrame.to_sql: Parameter "con" description should finish with "."
pandas.io.formats.style.Styler: Parameter "na_rep" description should finish with "."
pandas.io.formats.style.Styler.format: Parameter "formatter" description should finish with "."
pandas.io.formats.style.Styler.format: Parameter "na_rep" description should finish with "."

Cannot speak for the rest.

pandas.testing.assert_categorical_equal: Parameter "check_dtype" description should finish with "."
pandas.testing.assert_categorical_equal: Parameter "obj" description should finish with "."
pandas.testing.assert_extension_array_equal: Parameter "left" description should finish with "."
pandas.testing.assert_extension_array_equal: Parameter "right" description should finish with "."
pandas.testing.assert_interval_array_equal: Parameter "obj" description should finish with "."
pandas.testing.assert_sp_array_equal: Parameter "check_fill_value" description should finish with "."
pandas.eval: Parameter "truediv" description should finish with "."
pandas.PeriodIndex: Parameter "freq" description should finish with "."
pandas.core.window.rolling.Rolling.apply: Parameter "engine" description should finish with "."
pandas.core.window.rolling.Rolling.apply: Parameter "engine_kwargs" description should finish with "."
pandas.core.window.expanding.Expanding.apply: Parameter "engine" description should finish with "."
pandas.core.window.expanding.Expanding.apply: Parameter "engine_kwargs" description should finish with "."
pandas.core.groupby.DataFrameGroupBy.corr: Parameter "method" description should finish with "."

@MarcoGorelli
Copy link
Member

cool, feel free to any of the remaining ones if you want

feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants