ENH: Add Storage Options kwarg to read_table #43239
Conversation
alimcmaster1
added
the
IO Data
alimcmaster1
force-pushed
the
mcmali-storage
branch
from
606d64e to
c9eab65
Compare
| @@ -122,6 +123,17 @@ def test_csv_options(fsspectest): | |||
| assert fsspectest.test[0] == "csv_read" | |||
|
|
|||
|
|
|||
| def test_read_table_options(fsspectest): | |||
There was a problem hiding this comment.
Could we parametrize the test added back then?
There was a problem hiding this comment.
Technically changing the order of the arguments might break user code, but I don't think this is a real issue?
There was a problem hiding this comment.
Technically changing the order of the arguments might break user code, but I don't think this is a real issue?
Its a kwarg do you have an example of how this might break user code?
There was a problem hiding this comment.
Could we parametrize the test added back then?
Fair point they could be. The pattern used in the following tests in this file is the same. But I think thats better off as a sep issue.
test_csv_options
test_excel_options
test_arrowparquet_options
test_fastparquet_options
test_feather_options
test_pickle_options
There was a problem hiding this comment.
They aren't key word only yet, but as I said probably not relevant.
Yeah agree with the tests. Have not looked that closely, just checked the linked pr and saw that the test was the same, so was wondering
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
storage_optionsparameter missed inread_tablemethod? #39167Follow up from #35381 - looks like this was missed
Not sure if this is an enhancements or a bug given the docs already mention this arg is supported.
https://pandas.pydata.org/docs/reference/api/pandas.read_table.html