Skip to content

PERF: DataFrame(dict_of_categoricals) #43237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2021
Merged

PERF: DataFrame(dict_of_categoricals) #43237

merged 2 commits into from
Aug 27, 2021

Conversation

jbrockmendel
Copy link
Member 

from asv_bench.benchmarks.frame_ctor import *

self = FromDicts()
self.setup()

%timeit self.time_dict_of_categoricals()
1.48 ms ± 61.1 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)  # <- master
528 µs ± 2.75 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)  # <- PR

@alimcmaster1 alimcmaster1 added the Performance Memory or execution speed performance label Aug 26, 2021
@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Aug 26, 2021
alimcmaster1
alimcmaster1 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM

@jreback jreback merged commit 1530210 into pandas-dev:master Aug 27, 2021
@jbrockmendel jbrockmendel deleted the perf-dict_of_categoricals branch August 27, 2021 00:53
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@jbrockmendel @feefladder
PERF: DataFrame(dict_of_categoricals) (pandas-dev#43237)
facda93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Performance Memory or execution speed performance
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @alimcmaster1 @jreback