Skip to content

CLN: remove unused pandas-gbq tests #43231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 26, 2021

Closes #43214

These tests are not run in CI. I'll replace these with tests in the pandas-gbq repo (googleapis/python-bigquery-pandas#379)

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry (N/A)

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Aug 26, 2021
@alimcmaster1 alimcmaster1 added the Testing pandas testing functions or related to the test suite label Aug 26, 2021
@alimcmaster1
Copy link
Member

Yeah these used to run only on travis.

Taking Jeff's comments here as a +1 and LGTM

@alimcmaster1 alimcmaster1 merged commit 470a062 into pandas-dev:master Aug 26, 2021
@tswast tswast deleted the issue43214-gbq-testing branch August 26, 2021 20:27
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN: avoid use of service account keys in to_gbq and read_gbq tests
3 participants