Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: groupby agg fails silently with mixed dtypes #43213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: groupby agg fails silently with mixed dtypes #43213
Changes from 7 commits
91aa285
9b9b7af
d968e57
46a29e0
195db31
16e28db
854ecda
7dd27f3
309ee59
8d1bfb1
41471aa
3647f53
d6992e5
ab1fd87
23d2989
9039124
d75c57b
89a6bc7
64ca85a
8a0f5fe
4ae0d6b
ac51170
572f23c
183f245
62b5aac
625a751
9b0acd7
4b4618a
265b3bb
a55211a
753c7df
de86f72
2a29451
a37f1f9
00838be
a04d021
c9d6658
5db7155
5ccf385
9afd465
600b71e
fe13278
1aaf326
4ba8511
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these to pandas/tests/groupby/aggregate/test_aggreagte.py (or maybe test_cython) see where similar are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this actually casts to Float64? what were the results in 1.2.5? we should match them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. 1.2.5 was
int64, float64, int64
I will try to do that (didn't get a chance yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, yeah we want to have an exact match to 1.2.5; this can be changed going forwawrd for 1.4, but not on a regression patch.