Skip to content

TST: categorical reindex with added categories #43210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2021
Merged

TST: categorical reindex with added categories #43210

merged 3 commits into from
Aug 30, 2021

Conversation

Sheogorath27
Copy link
Contributor

The bug is specifically in the Interval index. The error arises in the example code from the issue while reindexing the categorical index with another categorical index(with new categories).

The test (test_cut_with_nonexact_categorical_indices) from PR 42425 implicitly works in a similar way.

@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Aug 25, 2021
@alimcmaster1 alimcmaster1 added the Testing pandas testing functions or related to the test suite label Aug 25, 2021
@alimcmaster1
Copy link
Member

Thanks for the PR @Sheogorath27 - mind taking a look at why CI is failing?

@Sheogorath27
Copy link
Contributor Author

I checked tests are passing locally. And I did not find any conflicts with the failed test.

@mroeschke
Copy link
Member

Could you add a unit test with the example in the original issue as well (for an additional smoke test)?

@Sheogorath27
Copy link
Contributor Author

Sheogorath27 commented Aug 28, 2021 •
edited
Loading

Test from PR 42425 is the same as the example in the issue. Should I duplicate it?

@alimcmaster1
Copy link
Member

Test from PR 42425 is the same as the example in the issue. Should I duplicate it?

That PR was never merged. What are you suggesting we duplicate?

@Sheogorath27
Copy link
Contributor Author

Test from PR 42425 is the same as the example in the issue. Should I duplicate it?

That PR was never merged. What are you suggesting we duplicate?

Sorry, I assumed PR was merged. I will add a new unit test.

@Sheogorath27
Copy link
Contributor Author

Sheogorath27 commented Aug 30, 2021 •
edited
Loading

Could you add a unit test with the example in the original issue as well (for an additional smoke test)?

I have added a new test based on the example from the issue.

@mroeschke mroeschke merged commit 375267f into pandas-dev:master Aug 30, 2021
@mroeschke
Copy link
Member

Thanks @Sheogorath27

@Sheogorath27 Sheogorath27 deleted the categorical-reindex branch August 30, 2021 18:23
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@Sheogorath27 @feefladder
TST: categorical reindex with added categories (pandas-dev#43210)
1c04a47 
* TST: categorical reindex with added categories

* Update test_reindex.py

* TST: Dataframe construct from series.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: creating DF from series with non exact categorical indices created from pd.cut
3 participants
@Sheogorath27 @alimcmaster1 @mroeschke