Skip to content

BUG: pickle Index[object] preserve dtype #43188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Aug 23, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

xref #43155

@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Aug 25, 2021
@simonjayhawkins simonjayhawkins added IO Pickle read_pickle, to_pickle Bug labels Aug 25, 2021
import pandas._testing as tm


def test_pickle_preserves_object_dtype():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you paramterize on all the index types? (i think we have a fixture)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can come back and add more tests that use the fixture, but id like to keep this test targeted at a specific bug

@jreback jreback merged commit 0625e99 into pandas-dev:master Sep 4, 2021
@jbrockmendel jbrockmendel deleted the perf-index-unpickle branch September 5, 2021 00:51
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug IO Pickle read_pickle, to_pickle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants