Skip to content

TST: MultiIndex with complex #43184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Conversation

debnathshoham
Copy link
Member

This has been resolved in the master. I think adding a test will close it.

{
"x": complex_data,
"y": non_complex_data1,
"z": non_complex_data2,
Copy link
Member

@phofl phofl Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you simply use 1 here, makes it easier to understand since this is not bug relevant, isn‘t it?

also maybe reduce number of rows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amended

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alimcmaster1 alimcmaster1 self-assigned this Aug 25, 2021
@alimcmaster1 alimcmaster1 added this to the 1.4 milestone Aug 26, 2021
@alimcmaster1 alimcmaster1 added Complex Complex Numbers Testing pandas testing functions or related to the test suite labels Aug 26, 2021
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - great to have more test for complex dtypes.

@alimcmaster1 alimcmaster1 merged commit d2a14f9 into pandas-dev:master Aug 26, 2021
@alimcmaster1 alimcmaster1 removed their assignment Aug 26, 2021
@debnathshoham debnathshoham deleted the gh42145 branch August 26, 2021 17:19
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complex Complex Numbers Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Imaginary part of complex numbers gets dropped when using a MultiIndex
3 participants