TST: Add testing to df.where() typecasting as per GH 42295 #43173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @maximilianaccardo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-26 01:52:01 UTC |
mroeschke
reviewed
Aug 23, 2021
| result = d1.where(pd.notnull(d1), None).dtypes | ||
| # make sure dtypes don't change | ||
| expected = d1.dtypes | ||
| tm.assert_series_equal(expected, result) |
There was a problem hiding this comment.
Instead of comparing the .dtype results. Could you compare the DataFrame result of result of d1.where(pd.notnull(d1), None)
There was a problem hiding this comment.
Yes, thanks for the review. I updated it.
mroeschke
added
the
Testing
added 2 commits
August 23, 2021 03:47
phofl
reviewed
Aug 23, 2021
| def test_where_columns_casting(): | ||
| # GH 42295 | ||
|
|
||
| d1 = DataFrame({"a": [1.0, 2.0], "b": [3, np.nan]}) |
There was a problem hiding this comment.
Please call df for consistency and create expected = df.copy() before applying where
There was a problem hiding this comment.
Please create expected before calling where.
phofl
approved these changes
Aug 25, 2021
mroeschke
approved these changes
Aug 26, 2021
|
Thanks @maximilianaccardo. Happy to have you tackle more issues that require tests. |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
…v#43173) * Add testing to df.where() typecasting as per GH 42295 * Fix style * Directly compare data frames * Fix pre-commit * Rename dataframe to df * create expected before calling where Co-authored-by: Maximilian Carr <[email protected]> Co-authored-by: Maximilian Carr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that df.where does not cast floats to integers.