Skip to content

TST: Test inequality w/ complex dtypes (GH28050) #43159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2021

Conversation

calvh
Copy link
Contributor

@calvh calvh commented Aug 21, 2021

Whats new::
Add a test to pandas/test/dtypes/test_dtypes.py

Remove https link to issue (keep issue number)
Save match message in variable for multiple use
@calvh
Copy link
Contributor Author

calvh commented Aug 22, 2021

@phofl thanks for the comments please see revision

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@phofl phofl added the Testing pandas testing functions or related to the test suite label Aug 22, 2021
@mroeschke mroeschke merged commit 49279c9 into pandas-dev:master Aug 22, 2021
@mroeschke
Copy link
Member

Thanks @calvh. The CI failures were unrelated.

@calvh calvh deleted the 28050-test-inequality-complex branch August 22, 2021 19:09
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
* TST: Test inequality w/ complex dtypes (GH28050)

Should raise TypeError

* Add test for complex dtype comparison using '<'

* Refactor code to reduce repetition

Remove https link to issue (keep issue number)
Save match message in variable for multiple use

* Combine arange call with DataFrame call in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NUM: inequality with complex dtypes
3 participants