-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Outer/right merge with EA dtypes cast to object #43152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
01358f6
BUG: Outer/right merge with EA dtypes cast to object
debnathshoham 0e02e8d
suggested edits
debnathshoham c4619ba
updated whatsnew; tweaked failing test
debnathshoham 9010b11
failing test tweak
debnathshoham 2a7838c
reverted failed tweaked test
debnathshoham e38ff20
xfailed test_handle_join_key_pass_array in 32bit
debnathshoham 5748ef9
Merge branch 'master' into gh40073
debnathshoham f2f7aac
skipif
debnathshoham 71059a4
Merge branch 'gh40073' of https://github.com/debnathshoham/pandas int…
debnathshoham 55add8b
skipif windows
debnathshoham 6db265a
skipif windows & 32
debnathshoham b34e562
changed or to and
debnathshoham 81360aa
xfail on windows/32bit
debnathshoham a088696
xfail on windows/32bit
debnathshoham b864d92
updated whatsnew as suggested
debnathshoham de0e84d
explicitly int64
debnathshoham 4a5e173
Merge branch 'master' into gh40073
debnathshoham c34dc58
Update doc/source/whatsnew/v1.3.3.rst
debnathshoham f89be6a
Merge branch 'master' into gh40073
debnathshoham f92baac
Merge branch 'gh40073' of https://github.com/debnathshoham/pandas int…
debnathshoham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe specify that the cast only occurs when those columns were being merged on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC what happened here was that
left
andouter
were always broken, so fixing those could be moved down into the bug fix section of the whatsnew.Then the regression portion could just focus on
right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, this bug was pertaining to
right
(regression) andouter
(had mentioned in the PR subject), also discussed in the bug comments.I will keep
right
in fixed regression, and moveouter
down to bug fix.