Skip to content

TYP: callable refactor for apply methods in styler #43148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Aug 21, 2021

unrelated question: if i'm in pandas-core can I be added as a maintainer to config.yml?

@attack68 attack68 requested a review from MarcoGorelli August 27, 2021 16:27
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is necessary because the return type isn't guaranteed to be Styler, right? If so, looks good to me

@MarcoGorelli
Copy link
Member

unrelated question: if i'm in pandas-core can I be added as a maintainer to config.yml?

Yes, absolutely - this should be part of the process of adding maintainers, but is often forgotten. Sorry for not having picked up on this sooner

@MarcoGorelli MarcoGorelli added the Typing type annotations, mypy/pyright type checking label Aug 27, 2021
@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Aug 27, 2021
@MarcoGorelli MarcoGorelli merged commit b9e90dc into pandas-dev:master Aug 27, 2021
@attack68
Copy link
Contributor Author

So, this is necessary because the return type isn't guaranteed to be Styler, right? If so, looks good to me

correct

@attack68 attack68 deleted the styler_callable_typing branch August 27, 2021 17:09
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants