-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: _form_blocks #43144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERF: _form_blocks #43144
Conversation
https://github.com/pandas-dev/pandas/pull/43144/checks?check_run_id=3386832245 looks like a real error |
Huh can't reproduce the failures locally, will have to dig into this |
OK, looks like in numpy<1.21 comparing np.dtype object to EA dtype object raises instead of returning False, so the itertools.groupby is failing. will figure out a workaround |
updated with np<1.21-compatiblity + green |
@jreback gentle ping; hoping to get this in before you take off |
items_dict: DefaultDict[str, list] = defaultdict(list) | ||
|
||
for i, name_idx in enumerate(range(len(arrays))): | ||
def _grouping_func(tup): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if u can type in a follow on
Orthogonal to #43142, one more optimization after these two are in.