Skip to content

REF: Replacing axis in with _get_axis_number(axis) #43131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

RohanTrix
Copy link
Contributor

@RohanTrix RohanTrix commented Aug 20, 2021

xref #43048. Refactored test_label_or_level_utils.py

…axis_number(axis)` in pandas/tests/generic/test_label_or_level_utils.py
@pep8speaks
Copy link

pep8speaks commented Aug 20, 2021

Hello @RohanTrix! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-20 17:24:56 UTC

@RohanTrix RohanTrix changed the title CLN: Replacing axis in with _get_axis_number(axis) REF: Replacing axis in with _get_axis_number(axis) Aug 20, 2021
@attack68
Copy link
Contributor

lgtm pending green tests

Comment on lines 144 to 145


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these blank lines. You get CI check errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jreback jreback added this to the 1.4 milestone Aug 20, 2021
@jreback jreback added the Refactor Internal refactoring of code label Aug 20, 2021
@jreback jreback merged commit 5410fb7 into pandas-dev:master Aug 20, 2021
@jreback
Copy link
Contributor

jreback commented Aug 20, 2021

thanks @RohanTrix very nice. Leavning the issue open if there are additional cases.

@RohanTrix
Copy link
Contributor Author

Thanks @jreback !

@RohanTrix RohanTrix deleted the axis-kwarg-factored branch August 23, 2021 08:28
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants