Skip to content

EHN: partially upgrade sql module for SQLAlchemy 2.0 compat #43116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2021

Conversation

fangchenli
Copy link
Member

xref #40686

@pep8speaks
Copy link

pep8speaks commented Aug 19, 2021

Hello @fangchenli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-20 04:05:22 UTC

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions IO SQL to_sql, read_sql, read_sql_query labels Aug 20, 2021
@jreback jreback added this to the 1.4 milestone Aug 20, 2021
@jreback jreback merged commit 4268618 into pandas-dev:master Aug 20, 2021
@jreback
Copy link
Contributor

jreback commented Aug 20, 2021

very nice @fangchenli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants